prevent recompiling by properly specifying build.rs #1005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wins
This is a decent improvement to our local development cycle.
Previously running
cargo test
after modifying a test took 5.5s to build on my machine, with this PR it takes 3s to build.I expect the improvement to be even more on machines with lower core counts than mine.
Investigation
By looking at
cargo test --no-run --timings
before and after the PR we can see what changed:Before:
After:
The build script i.e. build.rs was rerunning and this was forcing all of shotover-proxy to be rebuilt and any example binaries.
Afterwards only the test binary that we modified is being rebuilt.
Solution
The problem with our current setup is that unless instructed otherwise cargo will rerun the build.rs everytime a single file is changed in the package.
The
shotover-proxy/build.rs
is no longer needed, I assume the user of the env var it emits was moved intotest-helpers
ortokio-bin-process
, so I just removed it.The other remaining build.rs files have been changed to declare the env var that they take in so that cargo doesnt default to rerunning every time.
see: https://doc.rust-lang.org/cargo/reference/build-scripts.html#change-detection